-
Notifications
You must be signed in to change notification settings - Fork 75
Possibly fix #218 - next->_next might be unavailble. #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@cboulay for your consideration. I don't know exactly where it's going wrong, but for example if i close all the inlets in a loop (without deleting them) then the first works, and each subsequent stream_close results in:
e.g. for the inlets_10, there'll be that message 9 times. I don't know if this indicates a problem with the inlets sharing some pointer? How it is now, the tests pass, and my idea of copying the stream_info is probably not at all related to it. I'd be happy to make this into a fully fledged PR but I'd prefer to actually understand the problem rather than guess :) |
oh and for the sample destructor, obviously performance is super critical, while |
When cur is deleted, next might become invalid. I've run this test locally and it passes, but I also couldn't get it to fail with the previous implementation, but I see it failing in the test outputs.
If this invokes the test runner we can see if the issue persisits.